Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/bump: add --tap= flag #16830

Merged
merged 1 commit into from
Mar 6, 2024
Merged

dev-cmd/bump: add --tap= flag #16830

merged 1 commit into from
Mar 6, 2024

Conversation

jck112
Copy link
Contributor

@jck112 jck112 commented Mar 6, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Allow tap maintainers to run brew bump --tap <user>/<repo> to keep their formulae and casks up-to-date.

(Note: this is the same exact behavior as brew livecheck --tap <user/<repo>)

@ZhongRuoyu
Copy link
Member

You should be able to do it with brew bump <user>/<repo>/<formula>, just like brew install.

@jck112
Copy link
Contributor Author

jck112 commented Mar 6, 2024

You should be able to do it with brew bump <user>/<repo>/<formula>, just like brew install.

Yes it works for individual formula and casks. However if you want to bump your entire tap repository then you have to either maintain a list of all your formula / casks or generate it with some kind of custom script.

@bevanjkay
Copy link
Member

I appreciate you looking into this @jck112 - I'm running a subcommand to generate a list in my own tap's autobump workflow.

@Bo98
Copy link
Member

Bo98 commented Mar 6, 2024 •
edited
Loading

This is a good idea but I am tempted to add an error if tap.official? so no one does brew bump --tap=Homebrew/core.

@jck112
Copy link
Contributor Author

jck112 commented Mar 6, 2024

This is a good idea but I am tempted to add an error if tap.official? so no one does brew bump --tap=Homebrew/core.

Added the check as well as a test. Let me know if want any tweaks to the error message.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution to Homebrew/brew! Without people like you submitting PRs we couldn't run this project. You rock, @jck112!

@MikeMcQuaid MikeMcQuaid merged commit 54de70d into Homebrew:master Mar 6, 2024
26 checks passed
@jck112 jck112 deleted the bump-tap branch March 6, 2024 18:31
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jck112 @ZhongRuoyu @bevanjkay @Bo98 @MikeMcQuaid @carlocab